src: cast to v8::Value before using v8::EmbedderGraph::V8Node #52638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to disambiguate the call site for an upstream patch to support v8::Data in traced references and pass the Node.js integration in the V8 CI. When that lands in the upstream we can implement V8Node(const v8::Local<v8::Data>) in a follow-up. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Apr 22, 2024
aduh95
approved these changes
Apr 23, 2024
addaleax
approved these changes
Apr 23, 2024
anonrig
approved these changes
Apr 23, 2024
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7b2e3b8 |
pthier
pushed a commit
to v8/node
that referenced
this pull request
Apr 29, 2024
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
This is required to disambiguate the call site for an upstream patch to support v8::Data in traced references and pass the Node.js integration in the V8 CI. When that lands in the upstream we can implement V8Node(const v8::Local<v8::Data>) in a follow-up. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888 PR-URL: #52638 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
This is required to disambiguate the call site for an upstream patch to support v8::Data in traced references and pass the Node.js integration in the V8 CI. When that lands in the upstream we can implement V8Node(const v8::Local<v8::Data>) in a follow-up. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888 PR-URL: #52638 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
This is required to disambiguate the call site for an upstream patch to support v8::Data in traced references and pass the Node.js integration in the V8 CI. When that lands in the upstream we can implement V8Node(const v8::Local<v8::Data>) in a follow-up. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888 PR-URL: #52638 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
This is required to disambiguate the call site for an upstream patch to support v8::Data in traced references and pass the Node.js integration in the V8 CI. When that lands in the upstream we can implement V8Node(const v8::Local<v8::Data>) in a follow-up. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888 PR-URL: nodejs#52638 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to disambiguate the call site for an upstream patch to support v8::Data in traced references and pass the Node.js integration in the V8 CI. When that lands in the upstream we can implement V8Node(const v8::Localv8::Data) in a follow-up.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888